lightweight/right-tree
1
0
Fork 0
Code Issues 17 Pull requests Projects Releases Packages Wiki Activity Actions

Small misc improvements and modifications #21

New issue
Closed
opened 2021-11-09 12:50:38 +13:00 by danalambert · 17 comments
danalambert commented 2021-11-09 12:50:38 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link
  • Redirect to a different habitat image if such a zone is selected
  • Add zone specific filter rules (ignoring steps etc...)
  • Add forest position info to results
  • Fix image height for zone selection
  • Maori garden - ignore location information
  • Order plant list by the fields specified in the requirements
* [x] Redirect to a different habitat image if such a zone is selected * [x] Add zone specific filter rules (ignoring steps etc...) * [x] Add forest position info to results * [x] Fix image height for zone selection * [x] Maori garden - ignore location information * [x] Order plant list by the fields specified in the requirements
danalambert commented 2021-11-09 12:50:38 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

assigned to @danalambert

assigned to @danalambert
danalambert commented 2021-11-09 15:42:33 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

marked the checklist item Fix image height for zone selection as completed

marked the checklist item **Fix image height for zone selection** as completed
danalambert commented 2021-11-09 16:53:06 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

mentioned in merge request !18

mentioned in merge request !18
danalambert commented 2021-11-10 10:28:43 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

mentioned in merge request !19

mentioned in merge request !19
danalambert commented 2021-11-10 10:35:19 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

marked the checklist item Add forest position info to results as completed

marked the checklist item **Add forest position info to results** as completed
danalambert commented 2021-11-10 11:07:28 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

I'm debating what ways the filter ignores could be implemented. Two ways I'm thinking, one where the logic be stored in the model and one where it is hard-coded as part of the filter logic (in the view - make lists of zones that have ignores). I guess there's advantages and disadvantages of each (keeping logic together in the model and making it user configurable rather than making an arbitrary mapping in filters).

I'm leaning toward putting it as a model field/s (connected to the Zone model), however, then another choice will be if this is going to be one field that contains all filter ignores.

For example the one field would require a foreign key to another model say FilterIgnoreOptions to provide a multi select field with defined values, the output would look something like ['soil_order', 'eco_region'].

Alternately, we could create multiple fields for each filter ignore for example, we add to Zone model two boolean fields ignore_soil_order_filter and ignore_location_filter. This method is easier but less extendable in the future.

@alistairmcintyre thoughts?

I'm debating what ways the filter ignores could be implemented. Two ways I'm thinking, one where the logic be stored in the model and one where it is hard-coded as part of the filter logic (in the view - make lists of zones that have ignores). I guess there's advantages and disadvantages of each (keeping logic together in the model and making it user configurable rather than making an arbitrary mapping in filters). I'm leaning toward putting it as a model field/s (connected to the Zone model), however, then another choice will be if this is going to be one field that contains all filter ignores. For example the one field would require a foreign key to another model say `FilterIgnoreOptions` to provide a multi select field with defined values, the output would look something like `['soil_order', 'eco_region']`. Alternately, we could create multiple fields for each filter ignore for example, we add to Zone model two boolean fields `ignore_soil_order_filter` and `ignore_location_filter`. This method is easier but less extendable in the future. @alistairmcintyre thoughts?
alistairmcintyre commented 2021-11-10 11:44:20 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

I think this is why putting all the logic and flow on the backend is a bit gnarly. Creating additional models isn't part of the spec, and we should really try to stick within the parameters we've been given.

Adding boolean fields to the Zone model for now accomplishes the short term goal, while also leaving us open to adjustment in the future (as we can just modify what the api returns if necessary) so I think that's the more pragmatic choice at this stage (and we have to remember that YAGNI exists and we shouldn't over-engineer something when it's not required)

I think this is why putting all the logic and flow on the backend is a bit gnarly. Creating additional models isn't part of the spec, and we should really try to stick within the parameters we've been given. Adding boolean fields to the Zone model for now accomplishes the short term goal, while also leaving us open to adjustment in the future (as we can just modify what the api returns if necessary) so I think that's the more pragmatic choice at this stage (and we have to remember that YAGNI exists and we shouldn't over-engineer something when it's not required)
danalambert commented 2021-11-10 14:18:18 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

mentioned in merge request !20

mentioned in merge request !20
danalambert commented 2021-11-10 14:18:30 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

marked the checklist item Maori garden - ignore location information as completed

marked the checklist item **Maori garden - ignore location information** as completed
danalambert commented 2021-11-10 14:18:33 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

marked the checklist item Add zone specific filter rules (ignoring steps etc...) as completed

marked the checklist item **Add zone specific filter rules (ignoring steps etc...)** as completed
danalambert commented 2021-11-10 14:19:10 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

Can't complete Redirect to a different habitat image if such a zone is selected until we receive updated diagrams.

Can't complete `Redirect to a different habitat image if such a zone is selected` until we receive updated diagrams.
danalambert commented 2021-11-10 17:39:29 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

changed the description

changed the description
danalambert commented 2021-11-11 13:26:34 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

mentioned in merge request !22

mentioned in merge request !22
danalambert commented 2021-11-11 13:26:44 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

marked the checklist item Redirect to a different habitat image if such a zone is selected as completed

marked the checklist item **Redirect to a different habitat image if such a zone is selected** as completed
danalambert commented 2021-11-11 13:27:33 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

Have setup the code to handle redirects with a demo, will handle real setup when we receive the proper image diagrams.

Have setup the code to handle redirects with a demo, will handle real setup when we receive the proper image diagrams.
danalambert commented 2021-11-17 10:33:36 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

marked the checklist item Order plant list by the fields specified in the requirements as completed

marked the checklist item **Order plant list by the fields specified in the requirements** as completed
danalambert commented 2021-11-17 10:34:38 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

mentioned in merge request !23

mentioned in merge request !23
alistairmcintyre (Migrated from gitlab.catalyst.net.nz) closed this issue 2021-11-18 13:56:27 +13:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
v1.0.1
No results found.
Labels
Clear labels   
Bug

A software bug we've noticed. (These may not necessarily be show-stoppers)

  
Client: Biosphere Capital

   
Client: Central Hawkes Bay District Council

   
Client: Forward Works Viewer

   
Client: Kea/Kākā Databases

   
Client: Otorohanga District Council

   
Stage: Blocked

Something is causing us to be unable to currently fix this issue.

  
Stage: Doing

An issue that's assigned and being worked on

  
Stage: Peer review / Staging

An issue waiting to be given the all clear for production deployment.

  
Stage: Ready

For tickets that have been quanitifed, have acceptance criteria, and can be safely moved to the To Do column.

  
Stage: UAT AT

Work waiting to be deployed to production.

No labels
Bug
Client: Biosphere Capital
Client: Central Hawkes Bay District Council
Client: Forward Works Viewer
Client: Kea/Kākā Databases
Client: Otorohanga District Council
Stage: Blocked
Stage: Doing
Stage: Peer review / Staging
Stage: Ready
Stage: UAT AT
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lightweight/right-tree#21
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?