lightweight/right-tree
1
0
Fork 0
Code Issues 17 Pull requests Projects Releases Packages Wiki Activity Actions

[#40] Address search #89

Merged
mattn merged 6 commits from matt/40-batch into main 2023-02-10 14:22:49 +13:00
Conversation 11 Commits 6 Files changed 68 +18028 -22275
mattn commented 2023-02-08 15:23:36 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

#40

Gist is that I'm implementing another questionnaire, very similar to the one that exists, but instead of choosing location from a map you enter an address (works the same as FWV, but queries LINZ directly using the API as a proxy). The new endpoint is /apply - the idea is that you'll send your application in through the interface and receive a planting guide in the mail.

@satoshi If you wouldn't mind, could you give this a quick sanity check? Just making sure the code makes sense should suffice.

#40 Gist is that I'm implementing another questionnaire, very similar to the one that exists, but instead of choosing location from a map you enter an address (works the same as FWV, but queries LINZ directly using the API as a proxy). The new endpoint is /apply - the idea is that you'll send your application in through the interface and receive a planting guide in the mail. @satoshi If you wouldn't mind, could you give this a quick sanity check? Just making sure the code makes sense should suffice.
mattn commented 2023-02-08 15:23:37 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

assigned to @satoshi

assigned to @satoshi
satoshi commented 2023-02-08 17:24:03 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

need key attribute

need `key` attribute
satoshi commented 2023-02-08 17:24:04 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

This is probably fine but note that Suspense was still experimental in React 17. You might want to upgrade to 18.

This is probably fine but note that Suspense was still experimental in React 17. You might want to upgrade to 18.
satoshi commented 2023-02-08 17:24:04 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

The whole thing is wrapped in Box so this fragment shouldn't be needed.

The whole thing is wrapped in Box so this fragment shouldn't be needed.
satoshi commented 2023-02-08 17:24:04 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

The file name should be .jsx?

The file name should be .jsx?
satoshi commented 2023-02-08 17:24:05 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

Good work. Added comments but they're all minor.

Good work. Added comments but they're all minor.
mattn commented 2023-02-10 14:21:45 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/giscore/biosphere-capital/right-tree/-/merge_requests/44/diffs?diff_id=184969&start_sha=ff197cc1a885ae66393b2b41056c639162128d2c#c7cf91025db765d31c30708010b2f72999815301_18_17)
mattn commented 2023-02-10 14:21:46 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/giscore/biosphere-capital/right-tree/-/merge_requests/44/diffs?diff_id=184969&start_sha=ff197cc1a885ae66393b2b41056c639162128d2c#7a84c5d16f15828c04595c79592f85f24cdfb2f5_12_12)
mattn commented 2023-02-10 14:21:47 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/giscore/biosphere-capital/right-tree/-/merge_requests/44/diffs?diff_id=184969&start_sha=ff197cc1a885ae66393b2b41056c639162128d2c#cc3685f148bcb054378f95bbc937bf83eef25c24_59_0)
mattn commented 2023-02-10 14:21:49 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>0f36c79d - [#40] Review changes</li></ul> [Compare with previous version](/giscore/biosphere-capital/right-tree/-/merge_requests/44/diffs?diff_id=184969&start_sha=ff197cc1a885ae66393b2b41056c639162128d2c)
mattn commented 2023-02-10 14:21:50 +13:00 (Migrated from gitlab.catalyst.net.nz)
Copy link

resolved all threads

resolved all threads
mattn (Migrated from gitlab.catalyst.net.nz) merged commit into main 2023-02-10 14:22:50 +13:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

A software bug we've noticed. (These may not necessarily be show-stoppers)

  
Client: Biosphere Capital

   
Client: Central Hawkes Bay District Council

   
Client: Forward Works Viewer

   
Client: Kea/Kākā Databases

   
Client: Otorohanga District Council

   
Stage: Blocked

Something is causing us to be unable to currently fix this issue.

  
Stage: Doing

An issue that's assigned and being worked on

  
Stage: Peer review / Staging

An issue waiting to be given the all clear for production deployment.

  
Stage: Ready

For tickets that have been quanitifed, have acceptance criteria, and can be safely moved to the To Do column.

  
Stage: UAT AT

Work waiting to be deployed to production.

No labels
Bug
Client: Biosphere Capital
Client: Central Hawkes Bay District Council
Client: Forward Works Viewer
Client: Kea/Kākā Databases
Client: Otorohanga District Council
Stage: Blocked
Stage: Doing
Stage: Peer review / Staging
Stage: Ready
Stage: UAT AT
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lightweight/right-tree#89
No description provided.
Delete branch "matt/40-batch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?